fix: make a copy of response data in ResponseWriterInterceptor#89
Open
wardab0104 wants to merge 1 commit intoAccelByte:masterfrom
Open
fix: make a copy of response data in ResponseWriterInterceptor#89wardab0104 wants to merge 1 commit intoAccelByte:masterfrom
wardab0104 wants to merge 1 commit intoAccelByte:masterfrom
Conversation
Contributor
|
suggest to find the root cause. because this issue does not happen every time, if we must use this fix, this could affect the performance. wdyt? @wardab0104 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The data in ResponseWriterInterceptor will be changed from the beginning of the array, not replaced entirely, making the data not a valid json, it seems that the underlying array of the slice was changed somewhere
Debugging: (endpoint: /iam/v4/public/namespaces/{namespace}/users - PublicCreateUserV4)
After fix:
